Add language to make providing examples mandatory #178
Conversation
PULL_REQUEST_TEMPLATE.md
Outdated
| @@ -1,5 +1,9 @@ | |||
| <!-- | |||
|
|
|||
| All new RFCs must: | |||
|
|
|||
| * have examples of the proposed behavior, preferably in the form of a script (or scripts) which shows the proposed behavior. | |||
There was a problem hiding this comment.
sure - a pester script is certainly a valid script
There was a problem hiding this comment.
Indeed, but if we explicitly encourage Pester (doesn't necessarily have to be entirely mandatory) then we have some tests to work with right from the beginning as either the PS team or community members get to work on implementing the proposal. 🙂
There was a problem hiding this comment.
I am somewhat worried about only pester tests. Pester tests don't generally test formatting, which I believe is an important aspect of new behaviors. It's important to see the results of a new cmdlet. To date, the number of examples in the RFCs has been woefully low (hardly any), and it makes judging new behavior extremely difficult.
Co-Authored-By: Steve Lee <slee@microsoft.com>
No description provided.