Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commands module is causing errors for missing help languages #509

Closed
daviwil opened this issue Jun 11, 2017 · 0 comments
Closed

Commands module is causing errors for missing help languages #509

daviwil opened this issue Jun 11, 2017 · 0 comments
Labels
Issue-Bug A bug to squash.
Milestone

Comments

@daviwil
Copy link
Contributor

daviwil commented Jun 11, 2017

Looks like we need to use -ErrorAction Ignore on the Import-LocalizedData call here:

https://github.com/PowerShell/PowerShellEditorServices/blob/master/module/PowerShellEditorServices/Commands/PowerShellEditorServices.Commands.psm1#L1

Ideally we'd see the errors in case there's a legitimate problem but for now the logs are getting filled with this error (probably because of another issue in PowerShellContext) so it's better to cut down on the noise.

11/06/2017 11:20:02 AM [ERROR] - Method "ExecuteCommand" at line 539 of C:\projects\powershelleditorservices\src\PowerShellEditorServices\Session\PowerShellContext.cs

    Execution completed with errors:
    
    Cannot find the Windows PowerShell data file 'Strings.psd1' in directory 'C:\Users\muzza\.vscode\extensions\ms-vscode.powershell-1.3.1\modules\PowerShellEditorServices\Commands\en-GB\', or in any parent culture directories.
    
@daviwil daviwil added the Issue-Bug A bug to squash. label Jun 11, 2017
@daviwil daviwil added this to the 1.3.2 milestone Jun 11, 2017
daviwil added a commit to daviwil/PowerShellEditorServices that referenced this issue Jun 11, 2017
TylerLeonhardt pushed a commit to TylerLeonhardt/PowerShellEditorServices that referenced this issue Feb 26, 2019
…ncel-dbg-on-invalid-file-type

Fix PowerShell#503 cancel debug on invalid file types.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Bug A bug to squash.
Projects
None yet
Development

No branches or pull requests

1 participant