Skip to content

Add support for finding and installing PowerShell Gallery modules #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 30, 2016

Conversation

dfinke
Copy link
Contributor

@dfinke dfinke commented Jan 26, 2016

Enables execution of Find-Module, then the displaying of modules in a quick pick list, if one is selected, Install-Module is then invoked

@daviwil
Copy link
Contributor

daviwil commented Jan 26, 2016

Strange, how did we end up with Initial Commit twice?

@daviwil daviwil added this to the 0.4.0 milestone Jan 26, 2016
@dfinke
Copy link
Contributor Author

dfinke commented Jan 26, 2016

I should have labelled the Initial commit messages with Find... and Install....

I'll look at using the PSModuleMessage too.

@daviwil
Copy link
Contributor

daviwil commented Jan 26, 2016

Ahhhh ok, I thought the same commit got in there twice somehow :) No problem!

@daviwil
Copy link
Contributor

daviwil commented Jan 30, 2016

The changes look good! Can you rebase your branch so that my commit doesn't show up twice in the commit history? Here's the commands you'll need to use:

git reset origin/master
git add -A
git commit
git push -f origin spike-dcf-psgallery

new file:   src/PowerShellEditorServices.Protocol/LanguageServer/FindModuleRequest.cs
new file:   src/PowerShellEditorServices.Protocol/LanguageServer/InstallModuleRequest.cs
modified:   src/PowerShellEditorServices.Protocol/PowerShellEditorServices.Protocol.csproj
modified:   src/PowerShellEditorServices.Protocol/Server/LanguageServer.cs
@dfinke
Copy link
Contributor Author

dfinke commented Jan 30, 2016

I get this error.

git push -f origin spike-dcf-gallery

error: src refspec spike-dcf-gallery does not match any.
error: failed to push some refs to 'https://github.com/PowerShell/PowerShellEditorServices.git'

@daviwil
Copy link
Contributor

daviwil commented Jan 30, 2016

Yep, I realized I made a mistake and edited my previous comment, the branch name should be spike-dcf-psgallery

@dfinke dfinke force-pushed the spike-dcf-psgallery branch from 8e13ed6 to 479d635 Compare January 30, 2016 16:43
@daviwil daviwil changed the title Spike dcf psgallery Add support for finding and installing PowerShell Gallery modules Jan 30, 2016
daviwil added a commit that referenced this pull request Jan 30, 2016
Add support for finding and installing PowerShell Gallery modules
@daviwil daviwil merged commit a5cf548 into master Jan 30, 2016
@daviwil daviwil deleted the spike-dcf-psgallery branch April 26, 2017 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants