Skip to content

Check _analysisService is null #1175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Check _analysisService is null #1175

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
42536de
Check _analysisService is null
mattn Feb 1, 2020
1bd9b29
ditto
mattn Feb 1, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions src/PowerShellEditorServices/Services/TextDocument/Handlers/TextDocumentHandler.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,10 @@ public Task<Unit> Handle(DidChangeTextDocumentParams notification, CancellationT
#pragma warning disable CS4014
// Kick off script diagnostics without blocking the response
// TODO: Get all recently edited files in the workspace
_analysisService.RunScriptDiagnosticsAsync(new ScriptFile[] { changedFile });
if (_analysisService != null)
{
_analysisService.RunScriptDiagnosticsAsync(new ScriptFile[] { changedFile });
}
#pragma warning restore CS4014
return Unit.Task;
}
Expand Down Expand Up @@ -94,7 +97,10 @@ public Task<Unit> Handle(DidOpenTextDocumentParams notification, CancellationTok
#pragma warning disable CS4014
// Kick off script diagnostics without blocking the response
// TODO: Get all recently edited files in the workspace
_analysisService.RunScriptDiagnosticsAsync(new ScriptFile[] { openedFile });
if (_analysisService != null)
{
_analysisService.RunScriptDiagnosticsAsync(new ScriptFile[] { openedFile });
}
#pragma warning restore CS4014

_logger.LogTrace("Finished opening document.");
Expand All @@ -117,7 +123,10 @@ public Task<Unit> Handle(DidCloseTextDocumentParams notification, CancellationTo
if (fileToClose != null)
{
_workspaceService.CloseFile(fileToClose);
_analysisService.ClearMarkers(fileToClose);
if (_analysisService != null)
{
_analysisService.ClearMarkers(fileToClose);
}
}

_logger.LogTrace("Finished closing document.");
Expand Down