Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Read-Host behavior which mangles input #1207

Merged

Conversation

TylerLeonhardt
Copy link
Member

@TylerLeonhardt TylerLeonhardt commented Feb 25, 2020

fixes PowerShell/vscode-powershell#2291

So this class constructor is needed to run for temp sessions but it's not needed for regular sessions.

I confirmed the following worked properly:

  • Temp session with script: "Read-Host"
  • Regular session with script: "Read-Host"
  • Regular session with script: "'hi'"
    Temp session with script: "'hi'"

Eventually we want to get rid of this ExecuteScriptStringAsync for Constrained language mode support but this change gets us the expected behavior.

@TylerLeonhardt TylerLeonhardt changed the title also check for tempSession Fix Read-Host behavior which mangles input Feb 25, 2020
@TylerLeonhardt
Copy link
Member Author

Codacy Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- src/PowerShellEditorServices/Server/PsesDebugServer.cs  1
         

See the complete overview on Codacy

@TylerLeonhardt TylerLeonhardt merged commit 15a9afa into PowerShell:master Feb 26, 2020
@TylerLeonhardt TylerLeonhardt deleted the fix-characters-being-captured branch February 26, 2020 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Preview 2019.11.0/1 Read-Host paste dropping letters.
2 participants