Implementation for issue #98 - shorting file path completion list. #122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n list. This commit not only addresses issue PowerShell#98 but also improves completion list support overall for commands (shows resolved command or path to exe), parameters (shows parameter type) as well as .NET properties and methods (shows signature).
| var matches = Regex.Matches(completionDetails.ToolTipText, @"^\[(.+)\]"); | ||
| if ((matches.Count > 0) && (matches[0].Groups.Count > 1)) |
There was a problem hiding this comment.
This could be simplified by moving the parentheses outside of the square brackets in the regex so that the contents of match group 1 include the brackets. Not worth making the change if you're already done with the work though :)
There was a problem hiding this comment.
Good point. I can make that change and push it and it should show up on the PR.
There was a problem hiding this comment.
Cool! I'll merge it as soon as you're done with that. Nice work!
|
Sweet! Merged. |
daviwil
added a commit
that referenced
this pull request
Feb 2, 2016
…completion-path Implementation for issue #98 - shorting file path completion list.
TylerLeonhardt
pushed a commit
to TylerLeonhardt/PowerShellEditorServices
that referenced
this pull request
Feb 26, 2019
This adds a scriptAnalysis.settingsPath setting but uncovers some issues about how to be an absolute path back to the language host from the client. Depending on where the user "set" this setting a relative path has a different meaning. If set in .vscode\settings.json then relative probably should be relative to the workspaceRoot. In the global settings file, it should probably be the extensionInstallDir. If in the user's settings file, then what ... their home dir?
If we treated this like the other HostPaths then relative would *always* be relative to the extensionInstallDir. If we could get VSCode to expand ${workspaceRoot} that would allow the user to specify a path in the current workspace folder.
TylerLeonhardt
pushed a commit
to TylerLeonhardt/PowerShellEditorServices
that referenced
this pull request
Feb 26, 2019
Use empty string now to get the default (built-in) settings for script analysis. Tweaked the build script to fix some problems and to exclude the script analysis settings file. Also changed encoding the SampleModule.psd1 file to UTF8.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit not only addresses issue #98 but also improves completion list support overall for commands (shows resolved command or path to exe), parameters (shows parameter type) as well as .NET properties and methods (shows signature).