Skip to content

Add better logging for formatter and refactor it into 1 class #1228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 11, 2020
Merged

Add better logging for formatter and refactor it into 1 class #1228

merged 1 commit into from
Mar 11, 2020

Conversation

TylerLeonhardt
Copy link
Member

  • Adds some extra logging
  • Refactor into 1 class for formatting

@TylerLeonhardt TylerLeonhardt requested a review from rjmholt as a code owner March 11, 2020 18:33
@TylerLeonhardt
Copy link
Member Author

Codacy Here is an overview of what got changed by this pull request:

Issues
======
- Added 2

See the complete overview on Codacy

TylerLeonhardt
TylerLeonhardt commented Mar 11, 2020
View reviewed changes
src/PowerShellEditorServices/Services/TextDocument/Handlers/FormattingHandlers.cs

public DocumentFormattingHandler(ILoggerFactory factory, AnalysisService analysisService, ConfigurationService configurationService, WorkspaceService workspaceService)
private DocumentFormattingCapability _documentFormattingCapability;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codacy Issue found: Remove this unread private field '_documentFormattingCapability' or refactor the code to use its value.

TylerLeonhardt
TylerLeonhardt commented Mar 11, 2020
View reviewed changes
src/PowerShellEditorServices/Services/TextDocument/Handlers/FormattingHandlers.cs

public DocumentFormattingHandler(ILoggerFactory factory, AnalysisService analysisService, ConfigurationService configurationService, WorkspaceService workspaceService)
private DocumentFormattingCapability _documentFormattingCapability;
private DocumentRangeFormattingCapability _documentRangeFormattingCapability;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codacy Issue found: Remove this unread private field '_documentRangeFormattingCapability' or refactor the code to use its value.

@TylerLeonhardt TylerLeonhardt merged commit 487454a into PowerShell:master Mar 11, 2020
@TylerLeonhardt TylerLeonhardt deleted the add-better-logging-for-formatting branch March 11, 2020 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@rjmholt rjmholt rjmholt approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TylerLeonhardt @rjmholt