Ensure that errors are written to the console when debugging #1230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjmholt
requested review from
SeeminglyScience and
TylerLeonhardt
and removed request for
SeeminglyScience
|
Issues
======
+ Solved 1
- Added 1
Complexity increasing per file
==============================
- src/PowerShellEditorServices/Services/PowerShellContext/PowerShellContextService.cs 1
See the complete overview on Codacy |
| @@ -1948,7 +1954,7 @@ internal void WriteOutput(string outputString, bool includeNewLine) | |||
| } | |||
| } | |||
|
|
|||
| private void WriteExceptionToHost(RuntimeException e) | |||
| private Task WriteExceptionToHostAsync(RuntimeException e) | |||
There was a problem hiding this comment.
TylerLeonhardt
approved these changes
Mar 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes PowerShell/vscode-powershell#2534.
The PowerShell thread writing errors was never awaited and was being starved it seems. We now wait for the error writing to finish