Skip to content

Optimize when we run GetCommandInfoAsync #1237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 16, 2020
Merged

Optimize when we run GetCommandInfoAsync #1237

merged 2 commits into from
Mar 16, 2020

Conversation

TylerLeonhardt
Copy link
Member

@TylerLeonhardt TylerLeonhardt commented Mar 13, 2020 •
edited
Loading

Now we are certain that GetCommandInfoAsync will only run when we have a Function. I included Unknown as well just in case, but I could take that out.

We should no longer see these in logs:

2020-03-13 12:37:12.884 -07:00 [ERR] Execution of the following command(s) completed with errors:

    Microsoft.PowerShell.Core\Get-Command -Name -ErrorAction Ignore

^ Explanation: -Name is being passed in to Get-Command.

@TylerLeonhardt TylerLeonhardt requested a review from rjmholt as a code owner March 13, 2020 19:36
rjmholt
rjmholt approved these changes Mar 14, 2020
View reviewed changes
@TylerLeonhardt @rjmholt
spacing
d501724 
Co-Authored-By: Robert Holt <rjmholt@gmail.com>
@TylerLeonhardt TylerLeonhardt merged commit abf2496 into PowerShell:master Mar 16, 2020
@TylerLeonhardt TylerLeonhardt deleted the optimize-for-commands branch March 16, 2020 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@rjmholt rjmholt rjmholt approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TylerLeonhardt @rjmholt