Addresses issue #40 - improved parameter completion list order #124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This takes advantage of the fact that PowerShell returns us a list of parameter names already in the preferred order (common params at the end). We just need to make the SortText for each completion result preserve the initial order.
|
Forgot to mention. This only works with a >= |
| @@ -1031,6 +1034,18 @@ private static CompletionItemKind MapCompletionKind(CompletionType completionTyp | |||
| } | |||
| } | |||
|
|
|||
| // We want a special "sort order" for parameters that is not lexicographical. | |||
There was a problem hiding this comment.
Excellent comment, thank you!
|
Argh, that debug adapter test is really starting to annoy me. Your change is great though, merging it! |
daviwil
added a commit
that referenced
this pull request
Feb 2, 2016
…-completion-sorting Addresses issue #40 - improved parameter completion list order
rkeithhill
deleted the
rkeithhill/is40-improve-param-completion-sorting
branch
TylerLeonhardt
pushed a commit
to TylerLeonhardt/PowerShellEditorServices
that referenced
this pull request
Feb 26, 2019
This change adds support for loading both host-specific and host-agnostic profile scripts for both the current user and all users on the same system. For VS Code, the profile names are Microsoft.VSCode_profile.ps1 and profile.ps1. The new 'enableProfileLoading' setting controls whether profiles are loaded automatically when the language server starts up. For now this setting is turned off by default. Resolves PowerShell#124.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This takes advantage of the fact that PowerShell returns us a list of parameter names already in the preferred order (common params at the end). We just need to make the SortText for each completion result preserve the initial order.