Prevent some exceptions #1500
Merged
Prevent some exceptions #1500
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was actually the documented parameter, but at some point it changed to take a file. It was better to use the `_workspaceService` service directly and safely attempt to get the file than to require the user to do that beforehand.
Used by the `MonacoLanguageClient`. Because it has no real file backing, we had to check that no file was returned in the prior commit.
As it can fail if the editor is being re-initialized.
rjmholt
reviewed
Jun 15, 2021
src/PowerShellEditorServices/Services/Analysis/AnalysisService.cs
Outdated
Show resolved
Hide resolved
src/PowerShellEditorServices/Services/TextDocument/Handlers/CodeActionHandler.cs
Outdated
Show resolved
Hide resolved
src/PowerShellEditorServices/Services/Workspace/Handlers/ConfigurationHandler.cs
Outdated
Show resolved
Hide resolved
|
@rjmholt Applied. |
rjmholt
reviewed
Jun 15, 2021
src/PowerShellEditorServices/Services/Analysis/AnalysisService.cs
Outdated
Show resolved
Hide resolved
dkattan
reviewed
Jun 15, 2021
src/PowerShellEditorServices/Services/TextDocument/Handlers/CodeActionHandler.cs
Show resolved
Hide resolved
andyleejordan
force-pushed
the
andschwa/fixes
branch
from
2a140bd to
5cdfd8a
Compare
ghost
added
rjmholt
approved these changes
Jun 15, 2021
Co-authored-by: Robert Holt <rjmholt_msft@outlook.com>
andyleejordan
force-pushed
the
andschwa/fixes
branch
from
9dbb7eb to
f917e9b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1495, #1498, and #1476.