Skip to content

Re-implement legacy readline support #1584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Oct 15, 2021
Merged

Re-implement legacy readline support #1584

merged 12 commits into from
Oct 15, 2021

Conversation

rjmholt
Copy link
Contributor

@rjmholt rjmholt commented Oct 12, 2021

Resolves #1436.

This PR:

  • Consolidates some common functionality shared between the readline implementations and the host:
    • The secure string read function
    • CtrlC detection
  • Puts back the legacy readline functionality
  • Adds idle support for legacy readline

@ghost ghost added Area-Engine Area-ReadLine Issue-Bug A bug to squash. labels Oct 12, 2021
@rjmholt rjmholt requested a review from andyleejordan October 13, 2021 00:03
@rjmholt rjmholt marked this pull request as ready for review October 13, 2021 00:03
@rjmholt rjmholt force-pushed the pt-legacy-readline branch 3 times, most recently from 42cb727 to ee3af49 Compare October 14, 2021 17:13
andyleejordan
andyleejordan approved these changes Oct 14, 2021
View reviewed changes
SeeminglyScience
SeeminglyScience approved these changes Oct 14, 2021
View reviewed changes
Copy link
Collaborator

@SeeminglyScience SeeminglyScience left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! One minor comment

@rjmholt rjmholt force-pushed the pt-legacy-readline branch from 1214d10 to 43bddb1 Compare October 14, 2021 22:24
@rjmholt rjmholt merged commit 9fd0dfa into PowerShell:async-ps-consumer Oct 15, 2021
@rjmholt rjmholt deleted the pt-legacy-readline branch October 15, 2021 20:54
@rjmholt rjmholt mentioned this pull request Oct 28, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SeeminglyScience SeeminglyScience SeeminglyScience approved these changes

@andyleejordan andyleejordan andyleejordan approved these changes

Assignees
No one assigned
Labels
Area-Engine Area-ReadLine Issue-Bug A bug to squash.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rjmholt @andyleejordan @SeeminglyScience