Update build documentation to include platyPS requirement #2008
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyleejordan
force-pushed
the
andschwa/x64-macOS
branch
2 times, most recently
from
3dde3e3 to
94506b8
Compare
andyleejordan
force-pushed
the
andschwa/x64-macOS
branch
7 times, most recently
from
73b20c0 to
d8a67f4
Compare
SteveL-MSFT
reviewed
Mar 24, 2023
SteveL-MSFT
requested changes
Mar 24, 2023
Since it's always used post-build to generate the documentation, we have a `#requires` for it but forgot to add it to the documentation. Also suppress stderr for sysctl when checking if macOS is an Intel or Arm processor. On the former, it doesn't know what field we're querying.
Now using `use-package` to better install them, and setting `load-prefer-newer` which was probably the bug.
andyleejordan
force-pushed
the
andschwa/x64-macOS
branch
from
d8a67f4 to
92e681d
Compare
SteveL-MSFT
approved these changes
Mar 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since it's always used post-build to generate the documentation, we have a
#requiresfor it but forgot to add it to the documentation.Also suppress stderr for sysctl when checking if macOS is an Intel or Arm processor. On the former, it doesn't know what field we're querying.