Skip to content

Ignore cancellation of completion requests #2028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 23, 2023
Merged

Ignore cancellation of completion requests #2028

merged 1 commit into from
May 23, 2023

Conversation

andyleejordan
Copy link
Member

@andyleejordan andyleejordan commented May 22, 2023 •
edited
Loading

@andyleejordan andyleejordan requested a review from a team May 22, 2023 23:21
@andyleejordan
Copy link
Member Author

This should do the trick @JustinGrote!

@andyleejordan andyleejordan enabled auto-merge (squash) May 23, 2023 00:05
@andyleejordan andyleejordan force-pushed the andschwa/ignore-cancellation branch from f66089a to bd119b3 Compare May 23, 2023 00:09
@JustinGrote
Copy link
Collaborator

JustinGrote commented May 23, 2023 •
edited
Loading

LGTM, my testing shows it suppressed. Thanks!

SeeminglyScience
SeeminglyScience approved these changes May 23, 2023
View reviewed changes
Copy link
Collaborator

@SeeminglyScience SeeminglyScience left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@andyleejordan andyleejordan merged commit c43c4a9 into main May 23, 2023
@andyleejordan andyleejordan deleted the andschwa/ignore-cancellation branch May 23, 2023 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SeeminglyScience SeeminglyScience SeeminglyScience approved these changes

Assignees
No one assigned
Labels
Area-Logging Issue-Bug A bug to squash.
Projects
Flying Fox
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Handle GetCompletionsAsync cancellation better
3 participants
@andyleejordan @JustinGrote @SeeminglyScience