Wired up Show Information|Warning|Error Message #244
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks man! I'll help you get this finished up when I've got a few spare moments. |
daviwil
changed the title
| @@ -81,7 +87,7 @@ public void UnregisterCommand(string commandName) | |||
| public EditorContext GetEditorContext() | |||
| { | |||
| return this.editorOperations.GetEditorContext().Result; | |||
| } | |||
| } | |||
There was a problem hiding this comment.
Extra space sneaked in here ;)
* Add support for debug protocol setVariableRequest. * Cleaned up some comments in the SetVariable method and removed some exceptions that we no longer need to catch now that we aren't using System.Convert.ChangeType().
…-program PSES half of program -> script launch prop change.
Add unit tests for this functionality.
…tick-rule Add PSMisleadingBacktick rule to the default ruleset.
Add support for Hit Count breakpoints
Remove PSScriptAnalyzer submodule
This change introduces a new PowerShellVersionDetails class which contains additional details about the version and runtime of the current PowerShell session: version, GitCommitId, edition, and processor architecture. A new protocol request and response pair was added for gathering this version information from the editor client.
Add PowerShellVersionDetails class and PowerShellVersionRequest
This change fixes an issue where script output for very small scripts is not being written out reliably before the debug adapter terminates. The fix is to add an extra output flush before sending the TerminatedEvent back to the client. This fix is temporary until we get the REPL integration online. Resolves #138. Resolves PowerShell/vscode-powershell#284.
Fix issue with debugger output not being written for short scripts
This change makes some slight tweaks to the PowerShell version and architecture gathering code to improve the user experience in the host editors which display those values.
Improve PowerShell version and architecture gathering
Provide quickfix functionality
daviwil
changed the title
|
Thanks a lot for the PR, Doug, I appreciate it! I apologize for taking so long to get it fixed up and merged. |
TylerLeonhardt
pushed a commit
to TylerLeonhardt/PowerShellEditorServices
that referenced
this pull request
Feb 26, 2019
This change fixes PowerShell#244 which reports that the extension does not load when the user's username contains a space. This was caused by the script execution of Start-EditorServices.ps1 not being contained within quotes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is