-
Notifications
You must be signed in to change notification settings - Fork 237
Add feature to format PowerShell source files #332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This enables the client to send settings as a hashtable instead of pointing to a settings file for script analysis. Our current code structure allows us to pass either a set of rules or a settings file path but not both. However, to provide code formatting settings we not only need to send a settings file to configure the given rules but also the rules in a particular order. The best approach in this case is to update and send a settings hashtable everytime we request code formatting markers.
Oh, I just realized there's a build failure here in the PowerShell v3 and v4 API tests:
|
Yes, even I noticed it only a couple of minutes ago. PSv3 and PSv4 do not have the |
Damn, I think I had written a review comment about this in the past but I might have deleted it. Here's what you can do:
JObject comes from Newtonsoft.Json.Linq |
Seems like we're still getting the build failures from the use of PowerShellEditorServices/src/PowerShellEditorServices/Language/LanguageService.cs Line 480 in bfcec76
|
I forgot to remove the redundant method. The tests now don't fail on compilation for v3 and v4. |
Awesome, thanks a lot! Merging it. |
@daviwil Thanks! |
No description provided.