A couple of debug adapter fixes #333
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we had been serializing "request_seq" as a string in our reponses to VS Code's debug adapter client. Very recently their code changed such that our responses were no longer being handled correctly. This is due to a change on their side which assumes that "request_seq" will always be returned as an int. This change corrects that in our debug adapter message serialization.
This change improves how we access a remote runspace's InstanceID so that we don't incorrectly identify remote process runspace attach events because we've used the InstanceId from the local RemoteRunspace object instead of the $host.Runspace.InstanceId from the remote session.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.