Add CompletionItemKind.Folder. #364
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They finally added this in 1.9.0. Noticed as I was reading through the release notes.
|
I'm not sure how VSCode < 1.9 will handle an enum value it doesn't understand. If it ignores it then we're good. If not, then I guess we'd have to set the min version to 1.9. Here is what it looks like:
Hmm, interesting that the |
|
Damn, they finally added it! I would guess that it won't crash at the very least. If it does we'll just tell people to upgrade. |
TylerLeonhardt
pushed a commit
to TylerLeonhardt/PowerShellEditorServices
that referenced
this pull request
Feb 26, 2019
* Add support for debug configurationSnippets. Rename debug target from "PowerShell" to "PowerShell Launch (current file)" this makes room for an eventual "PowerShell Attach" debug target. Fix PowerShell#364. * Replace tabs with spaces in copy/pasted config.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They finally added this in 1.9.0. Noticed as I was reading through the release notes.