Refactor runspace creation to enable more design improvements #467
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change is the first step toward moving runspace and feature creation to the host's entry point so that it can be more configurable. The creation of EditorSession is now handled by the EditorServicesHost. This is the start of further refactoring so expect more changes.
This change moves the creation of PowerShellContext instances outside of the EditorSession class so that runspace creation and configuration can be managed at the host layer.
This change moves runspace creation outside of PowerShellContext so that the runspace can be configured more easily at the host level. It also changes the relationship between the ConsoleServicePSHost and ConsoleService so that the latter now gets created by the former. This is leading up to a change where the behavior of these two classes will be merged into the PSHost implementation.
This change removes the try/catch from Start-EditorServicesHost so that any initialization errors get written directly instead of wrapped in a less effective form of output.
daviwil
force-pushed
the
runspace-creation
branch
from
d948fdc to
28233de
Compare
TylerLeonhardt
pushed a commit
to TylerLeonhardt/PowerShellEditorServices
that referenced
this pull request
Feb 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change kicks off a larger refactoring of how PowerShell Editor Services is initialized. The goal here is to move toward a more granular interface design which can be exposed as an extensibility API. I'll be working toward this incrementally over the next few releases.