Bug fixes and improvements for 0.2.0 #51
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change updates the SessionPSHostRawUserInterface class to get rid of most instances of throwing NotImplementedException. When debugging, if a script invokes a method that causes the raw UI interface to be touched, those methods shouldn't cause errors to appear. This change reduces the possibility of the user seeing errors due to this reason.
This change introduces the 'workspace/didChangeConfiguration' notification which the client will send to the language server when the user changes their settings. It also introduces a new configuration section for script analysis settings so that the user can turn on/off script analysis. More settings will be added later.
This change fixes an issue which causes high CPU usage and a delay when an application path is completed or hovered over. This is due to an unnecesary call to Get-Help which takes some time before it returns in this case.
This change enables language features for in-memory files such as untitled files and diff comparison files which show up in VS Code's Git diff viewer. When a file is sent in with an 'inmemory' or 'untitled' URI, it gets treated like a normal file.
In a previous commit, PowerShellSession was renamed to PowerShellContext. EditorServices.PowerShellSession was accidentally renamed to EditorServices.powerShellContext with a camel-cased name. This change corrects the casing on that property.
This change gives a namespace to the 'showonlinehelp' message type, making it 'powerShell/showOnlineHelp'. Also changes the request parameter type to a string and uses PSCommand.AddCommand, etc to avoid script injection attacks.
|
Hi @daviwil, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
TTYL, MSBOT; |
daviwil
added a commit
that referenced
this pull request
Nov 21, 2015
Bug fixes and improvements for 0.2.0
TylerLeonhardt
pushed a commit
to TylerLeonhardt/PowerShellEditorServices
that referenced
this pull request
Feb 26, 2019
package.json: use ${workspaceRoot}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.