Fix hang when debug adapter finishes executing #69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daviwil
force-pushed
the
daviwil/fix-debug-hang
branch
5 times, most recently
from
f48e105 to
7a474c3
Compare
This change fixes a hang that was caused by the recent refactoring of host process server implementations. In the debug adapter implementation, the PowerShellContext was not being disposed at shutdown which was causing the process to stay open because the associated threads were still alive. This change adds the necessary ProtocolServer.Shutdown implementation.
daviwil
force-pushed
the
daviwil/fix-debug-hang
branch
from
7a474c3 to
0aebf95
Compare
daviwil
added a commit
that referenced
this pull request
Dec 11, 2015
Fix hang when debug adapter finishes executing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes a hang that was caused by the recent refactoring of host
process server implementations. In the debug adapter implementation, the
PowerShellContext was not being disposed at shutdown which was causing the
process to stay open because the associated threads were still alive.
This change adds the necessary ProtocolServer.Shutdown implementation.