Skip to content

Fix debugging deadlock #807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 8, 2018
Merged

Fix debugging deadlock #807

merged 3 commits into from
Dec 8, 2018

Conversation

TylerLeonhardt
Copy link
Member

@TylerLeonhardt TylerLeonhardt commented Dec 7, 2018 •
edited
Loading

This fixes PowerShell/vscode-powershell#1634

I moved the calls to WaitForConnectionAsync into the thread that they will be awaited on.

@TylerLeonhardt TylerLeonhardt mentioned this pull request Dec 7, 2018
Closed
rjmholt
rjmholt approved these changes Dec 8, 2018
View reviewed changes
Copy link
Contributor

@rjmholt rjmholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TylerLeonhardt TylerLeonhardt merged commit ee227f1 into master Dec 8, 2018
@TylerLeonhardt TylerLeonhardt deleted the fix-debugging-deadlock branch December 8, 2018 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkeithhill rkeithhill Awaiting requested review from rkeithhill

@SeeminglyScience SeeminglyScience Awaiting requested review from SeeminglyScience

1 more reviewer

@rjmholt rjmholt rjmholt approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

F5 / Ctrl+F5 stops working while Run Active file in Active Terminal with Shift+CTRL+P works
2 participants
@TylerLeonhardt @rjmholt