Skip to content

Backport #974 #994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 27, 2019
Merged

Backport #974 #994

merged 3 commits into from
Jul 27, 2019

Conversation

rjmholt
Copy link
Contributor

@rjmholt rjmholt commented Jul 24, 2019 •
edited
Loading

Backport of #974

@rjmholt rjmholt requested a review from TylerLeonhardt July 24, 2019 01:38
@TylerLeonhardt
Copy link
Member

hmm something’s off here…

@TylerLeonhardt TylerLeonhardt self-requested a review July 26, 2019 00:09
TylerLeonhardt
TylerLeonhardt approved these changes Jul 27, 2019
View reviewed changes
Copy link
Member

@TylerLeonhardt TylerLeonhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Odd fix but ok LGTM

@rjmholt rjmholt merged commit 4518fa1 into PowerShell:legacy/1.x Jul 27, 2019
@rjmholt rjmholt deleted the legacy/format-analysis-crash branch December 11, 2019 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@TylerLeonhardt TylerLeonhardt TylerLeonhardt approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rjmholt @TylerLeonhardt