Fix race condition when updating password #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes three problems found when investigation Issue (#79).
There was a race condition that prevented changing password (either directly or through changing store configuration), where the password variable reference is cleared before it is through being used. Fix is to pass a copy of the password so that the source variable reference can be used repeatedly.
Error information when updating the configuration failed, was not being surfaced, causing confusion when update failed.
Updating the password would sometimes corrupt the store data, because of ordering changes in the metadata. Fix is to directly set metadata blob offset and size information during update.