Skip to content

Conversation

tgauth
Copy link
Collaborator

@tgauth tgauth commented Sep 18, 2025

PR Summary

  • ssh-keygen was warning that fido credentials were being overwritten, but the current Windows logic does not overwrite existing credentials on FIDO authenticators anyway, so this warning is unnecessary.

PR Context

@tgauth tgauth changed the title skip key_lookup() on Windows fix resident key generation message Sep 18, 2025
@tgauth
Copy link
Collaborator Author

tgauth commented Sep 18, 2025

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes an unnecessary warning about FIDO credentials being overwritten on Windows. The change removes conditional compilation code that was bypassing key lookup functionality and instead conditionally skips the key lookup check on Windows platforms where credentials are not overwritten.

  • Removes HAVE_FIDO_DEV_IS_WINHELLO conditional compilation from key_lookup function
  • Adds Windows-specific conditional compilation to skip key lookup in sk_enroll function
  • Adds explanatory comments about Windows behavior regarding credential overwriting

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@tgauth tgauth merged commit 1b893e6 into PowerShell:latestw_all Sep 22, 2025
4 checks passed
@tgauth tgauth deleted the update-fido-logging branch September 22, 2025 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong check / message when creating resident keys
2 participants