Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clicking functions in the debugger call stack does not navigate to the correct line #837

Closed
daviwil opened this issue Jun 7, 2017 · 1 comment
Closed

Clicking functions in the debugger call stack does not navigate to the correct line #837

daviwil opened this issue Jun 7, 2017 · 1 comment
Assignees
@rkeithhill
Labels
Area-Debugging Issue-Bug A bug to squash.
Milestone
1.3.2

Comments

@daviwil
Copy link
Contributor

daviwil commented Jun 7, 2017

I think some of the recent debug adapter protocol changes in VS Code might have broken our call stack view. When you click on functions in the call stack they don't seem to navigate to the correct line. Also looks like the line/column information on the call stack items isn't being displayed anymore.

Example here: https://youtu.be/DxFQ4uf9d7k?t=37m13s
@daviwil daviwil added Area-Debugging Issue-Bug A bug to squash. labels Jun 7, 2017
@daviwil daviwil added this to the June 2017 milestone Jun 7, 2017
@rkeithhill rkeithhill self-assigned this Jun 10, 2017
@daviwil daviwil modified the milestones: 1.3.2, June 2017 Jun 11, 2017
@daviwil
Copy link
Contributor Author

daviwil commented Jun 11, 2017

Fixed with PR PowerShell/PowerShellEditorServices#508

@daviwil daviwil closed this as completed Jun 11, 2017
@daviwil daviwil mentioned this issue Jun 11, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rkeithhill rkeithhill

Labels
Area-Debugging Issue-Bug A bug to squash.
Projects
None yet
Milestone
1.3.2
Development

No branches or pull requests
2 participants
@daviwil @rkeithhill