Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Preview mechanism #1707

Merged

Conversation

Projects
None yet
3 participants
@TylerLeonhardt
Copy link
Member

TylerLeonhardt commented Jan 19, 2019

PR Summary

This removes the dependency on the name of the extension being "ms-vscode.PowerShell". It's a bit of a workaround until this is resolved.

Also, this allows you to build preview versions the extension that have the name "PowerShell Preview". To build a preview version of the extension, that is to say,
a version of the extension named "PowerShell Preview",
You can simply change the version in the package.json to include -preview at the end.

When you build, this will:

  • Add a warning to the top of the README.md to warn users not to have the stable and preview version enabled at the same time
  • Adds "Preview" in a few places in the package.json

PR Checklist

Note: Tick the boxes below that apply to this pull request by putting an x between the square brackets.
Please mark anything not applicable to this PR NA.

  • PR has a meaningful title
  • Summarized changes
  • This PR is ready to merge and is not work in progress
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready

@TylerLeonhardt TylerLeonhardt requested review from rkeithhill and rjmholt Jan 19, 2019

@TylerLeonhardt TylerLeonhardt force-pushed the TylerLeonhardt:support-preview-build branch from 9d295c4 to ab3df78 Jan 19, 2019

@rkeithhill

This comment has been minimized.

Copy link
Collaborator

rkeithhill commented Jan 22, 2019

Can we query the loaded extensions and if we see an already loaded mscode-powershell of some sort, pop a warning dialog telling the user to disable one of the two extensions?

task UpdateReadme {
$newReadmeTop = '# PowerShell Language Support for Visual Studio Code
> ## ATTENTION: This is the PREVIEW version of the PowerShell extension for VSCode which contains features that are being evaluated for stable

This comment has been minimized.

Copy link
@rjmholt

rjmholt Jan 22, 2019

Member

I would maybe also make a note about supporting PS 5.1+

This comment has been minimized.

Copy link
@TylerLeonhardt

TylerLeonhardt Jan 22, 2019

Author Member

added. Although in the future both stable and preview will only support 5.1+

@TylerLeonhardt

This comment has been minimized.

Copy link
Member Author

TylerLeonhardt commented Jan 22, 2019

@rkeithhill I thought it couldn't be done... but I figured it out :)

disable

I don't think I can programmatically disable one or the other... but at least this is in their face.

@rkeithhill
Copy link
Collaborator

rkeithhill left a comment

LGTM

@TylerLeonhardt TylerLeonhardt merged commit 12c3510 into PowerShell:master Jan 22, 2019

3 of 4 checks passed

Codacy/PR Quality Review Hang in there, Codacy is reviewing your Pull request.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla All CLA requirements met.
Details

@TylerLeonhardt TylerLeonhardt deleted the TylerLeonhardt:support-preview-build branch Jan 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.