Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds the Install-VSCode.ps1 script to signing #1749

Merged

Conversation

Projects
None yet
2 participants
@TylerLeonhardt
Copy link
Member

commented Feb 8, 2019

PR Summary

Now we can release this more easily! Yay!

PR Checklist

Note: Tick the boxes below that apply to this pull request by putting an x between the square brackets.
Please mark anything not applicable to this PR NA.

  • PR has a meaningful title
  • Summarized changes
  • This PR is ready to merge and is not work in progress
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready

@TylerLeonhardt TylerLeonhardt requested a review from rjmholt Feb 8, 2019

@rjmholt

rjmholt approved these changes Feb 8, 2019

@TylerLeonhardt TylerLeonhardt merged commit 919a3a4 into PowerShell:master Feb 8, 2019

4 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla All CLA requirements met.
Details

@TylerLeonhardt TylerLeonhardt deleted the TylerLeonhardt:test-signing-install-vscode branch Feb 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.