Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workspace file to load both vscode-powershell and PSES #2645

Merged

Conversation

rkeithhill
Copy link
Collaborator

PR Summary

It is convenient to have both the extension and PSES loaded at the same time into VSCode. I would think that anyone working on the extension would want that. The name I have for it currently is extension-dev.code-workspace but I'm open to whatever name folks prefer. If we don't want this then I'd like to instead add an entry to .gitignore to ignore *.code-workspace files. That said, I don't see much harm in adding the workspace file. Folks don't have to use it.

image

PR Checklist

Note: Tick the boxes below that apply to this pull request by putting an x between the square brackets.
Please mark anything not applicable to this PR NA.

  • PR has a meaningful title
  • Summarized changes
  • PR has tests
  • This PR is ready to merge and is not work in progress
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready

Copy link
Member

@TylerLeonhardt TylerLeonhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM I was thinking about this recently too

@rkeithhill rkeithhill merged commit c6ccc68 into PowerShell:master Apr 20, 2020
@rkeithhill rkeithhill deleted the rkeithhill/add-workspace-file branch April 20, 2020 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants