Fixed crash when running pester older than 3.4.5 #2888
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calling Invoke-Pester with the -show param was breaking tests if running a version of pester older than 3.4.5 Moved logic for building spalt to call invoke-pester into a function and only added the show parameter if running pester 3.4.5 or newer
|
|
TylerLeonhardt
approved these changes
Aug 13, 2020
|
cc @nohwnd in case you wanna review. |
Co-authored-by: Tyler James Leonhardt <tylerl0706@gmail.com>
Co-authored-by: Tyler James Leonhardt <tylerl0706@gmail.com>
rjmholt
approved these changes
Aug 13, 2020
nohwnd
approved these changes
Aug 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Calling Invoke-Pester with the -show param would
throw and exception if running a version of pester
older than 3.4.5
Moved logic for building spalt to call
invoke-pester into a function and only added the
show parameter if running pester 3.4.5 or newer
PR Checklist
Note: Tick the boxes below that apply to this pull request by putting an
xbetween the square brackets.Please mark anything not applicable to this PR
NA.NAPR has testsWIP:to the beginning of the title and remove the prefix when the PR is ready