Skip to content

Conversation

Tyriar
Copy link
Contributor

@Tyriar Tyriar commented Mar 11, 2021

Fixes #3236

PR Summary

Title says it

PR Checklist

Note: Tick the boxes below that apply to this pull request by putting an x between the square brackets.
Please mark anything not applicable to this PR NA.

  • PR has a meaningful title
  • Summarized changes
  • PR has tests NA
  • This PR is ready to merge and is not work in progress
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready

@andyleejordan
Copy link
Member

Thanks @Tyriar! Is there a handy guide for extension/editor consistencies like this I should refer to? Like VS Code extension "best practices."

@andyleejordan andyleejordan added Area-UI Issue-Enhancement A feature request (enhancement). labels Mar 11, 2021
@andyleejordan andyleejordan merged commit 3f47abf into PowerShell:master Mar 11, 2021
@Tyriar
Copy link
Contributor Author

Tyriar commented Mar 11, 2021

There is actually and it's only like a month old: https://code.visualstudio.com/api/references/extension-guidelines

If you have any thoughts on the guide feel free to open issues under https://github.com/microsoft/vscode-docs

@Tyriar Tyriar deleted the tyriar/notification branch March 11, 2021 18:42
@andyleejordan
Copy link
Member

Niiice, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-UI Issue-Enhancement A feature request (enhancement).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use consistent "Don't Show Again" language in notification
2 participants