Skip to content

Allow PowerShell session to start and stop the debugger interface #3542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 7, 2021
Merged

Allow PowerShell session to start and stop the debugger interface #3542

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1353a7f
Remove unneeded launch configuration
andyleejordan Sep 2, 2021
e6d768c
Add `stopDebugger` notification
andyleejordan Sep 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 0 additions & 15 deletions .vscode/launch.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,21 +16,6 @@
],
"preLaunchTask": "Build"
},
{
"name": "Launch Extension (Build client only)",
"type": "extensionHost",
"request": "launch",
"runtimeExecutable": "${execPath}",
"args": [
"--extensionDevelopmentPath=${workspaceFolder}"
],
"stopOnEntry": false,
"sourceMaps": true,
"outFiles": [
"${workspaceFolder}/out/src/**/*.js"
],
"preLaunchTask": "Build"
},
{
"name": "Launch Extension Tests",
"type": "extensionHost",
Expand Down
9 changes: 7 additions & 2 deletions .vscode/tasks.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,28 +40,33 @@
"label": "Restore",
"type": "shell",
"command": "Invoke-Build Restore",
"problemMatcher": []
},
{
"label": "Clean",
"type": "shell",
"command": "Invoke-Build Clean",
"problemMatcher": []
},
{
"label": "Build",
"type": "shell",
"command": "Invoke-Build Build",
"group": "build",
"problemMatcher": [],
"group": "build"
},
{
"label": "Test",
"type": "shell",
"command": "Invoke-Build Test",
"group": "test",
"problemMatcher": [],
"group": "test"
},
{
"label": "Package",
"type": "shell",
"command": "Invoke-Build Package",
"problemMatcher": [],
"group": "build"
}
]
Expand Down
9 changes: 9 additions & 0 deletions src/features/DebugSession.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,9 @@ import { LanguageClientConsumer } from "../languageClientConsumer";
export const StartDebuggerNotificationType =
new NotificationType<void>("powerShell/startDebugger");

export const StopDebuggerNotificationType =
new NotificationType<void>("powerShell/stopDebugger");

export class DebugSessionFeature extends LanguageClientConsumer
implements DebugConfigurationProvider, vscode.DebugAdapterDescriptorFactory {

Expand Down Expand Up @@ -61,6 +64,12 @@ export class DebugSessionFeature extends LanguageClientConsumer
type: "PowerShell",
name: "PowerShell Interactive Session",
}));

languageClient.onNotification(
StopDebuggerNotificationType,
() =>
vscode.debug.stopDebugging(undefined)
);
}

public async provideDebugConfigurations(
Expand Down