Enable strict TypeScript mode
#4206
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyleejordan
added
Issue-Enhancement
andyleejordan
force-pushed
the
andschwa/strict
branch
from
3022dc5 to
a2b6a28
Compare
|
Hey @SeeminglyScience I did it! I hope. There was...some refactoring involved. |
andyleejordan
force-pushed
the
andschwa/strict
branch
from
6c34480 to
bddc3e3
Compare
andyleejordan
force-pushed
the
andschwa/strict
branch
from
bddc3e3 to
701a510
Compare
andyleejordan
force-pushed
the
andschwa/strict
branch
3 times, most recently
from
44437e4 to
b04a4d1
Compare
Was mostly whitespace 🤷
andyleejordan
force-pushed
the
andschwa/strict
branch
from
b04a4d1 to
b8189fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So we're actually using TypeScript properly with type checking. Resolves #3561.