Skip to content

Only check a script's extension if a script file was given #4227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 24, 2022
Merged

Only check a script's extension if a script file was given #4227

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions src/features/DebugSession.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ import Settings = require("../settings");
import { Logger } from "../logging";
import { LanguageClientConsumer } from "../languageClientConsumer";
import path = require("path");
import utils = require("../utils");

export const StartDebuggerNotificationType =
new NotificationType<void>("powerShell/startDebugger");
Expand Down Expand Up @@ -244,17 +245,21 @@ export class DebugSessionFeature extends LanguageClientConsumer
}

// Check the temporary console setting for untitled documents only, and
// check the document extension for everything else.
// check the document extension for if the script is an extant file (it
// could be inline).
if (config.untitled_document) {
if (config.createTemporaryIntegratedConsole) {
await vscode.window.showErrorMessage("Debugging untitled files in a temporary console is not supported.");
return undefined;
}
} else if (config.script) {
const ext = path.extname(config.script).toLowerCase();
if (!(ext === ".ps1" || ext === ".psm1")) {
await vscode.window.showErrorMessage(`PowerShell does not support debugging this file type: '${path.basename(config.script)}'`);
return undefined;
// TODO: Why even bother with this complexity?
if (await utils.checkIfFileExists(config.script)) {
const ext = path.extname(config.script).toLowerCase();
if (!(ext === ".ps1" || ext === ".psm1")) {
await vscode.window.showErrorMessage(`PowerShell does not support debugging this file type: '${path.basename(config.script)}'`);
return undefined;
}
}
}

Expand Down