Robustify startup, error handling, and logging #4584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyleejordan
force-pushed
the
andschwa/robust-startup
branch
4 times, most recently
from
a4695cd
to
c1a3621
Compare
|
This got big enough I split it out into sensible commits. |
Return `undefined` instead.
This addition is what spurned the rest of the following changes. It made it really easy to test the robustness of our start/stop/restart logic.
Includes some reorganization, a new cancellation token, and a bunch of bug fixes. We can now consistently restart the language server without losing track of the Extension Terminal, even if it's still starting up. Our `SessionStatus` is now actually useful, and the logical flow actually makes sense. Plus the giant methods have been broken up and error handling is consistent.
andyleejordan
force-pushed
the
andschwa/robust-startup
branch
from
c1a3621
to
5304fa3
Compare
andyleejordan
force-pushed
the
andschwa/robust-startup
branch
from
ed2a82e
to
5304fa3
Compare
andyleejordan
force-pushed
the
andschwa/robust-startup
branch
from
86e16f0
to
aff6982
Compare
|
Wow it really was just the timeout 😬 |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a couple late nights that resulted in an overhaul of our startup, error handling, and logging logic. Mostly because I realized how dang easy it was to get things into a funky state when I added
editorServicesWaitForDebuggerto the list of settings that will prompt for a restart. This made it really easy to test, especially in the "still starting up" state. It is still possible to generate perhaps more error messages than I'd like, but they mostly come from the LSP client library. In fact, the last bug I tracked down is that if the client failed to start, it can't be stopped (which throws an exception) AND it can't be disposed, the latter of which I think is an upstream bug I'll need to investigate.