Skip to content

Find shell integration module #5217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 17, 2025
Merged

Find shell integration module #5217

merged 1 commit into from
Jun 17, 2025

Conversation

andyleejordan
Copy link
Member

@Copilot Copilot AI review requested due to automatic review settings June 17, 2025 21:21
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the logic for locating the PowerShell shell integration script based on the VS Code version.

  • Bump the semver threshold to >=1.102 and update the reference PR link.
  • Simplify folder paths to always use common/scripts.
  • Switch the script filename to .psm1 for newer versions, falling back to .ps1.
Comments suppressed due to low confidence (3)

src/utils.ts:12

  • The comment above the version check references only the PR for folder relocations; consider updating it to mention the change in file extension logic (using .psm1) introduced in this PR for clarity.
// See https://github.com/microsoft/vscode/pull/251303

src/utils.ts:13

  • [nitpick] The variable name shellIntegrationMoved is ambiguous given its new responsibility of also selecting the .psm1 extension; consider renaming it to something like usePsm1IntegrationModule or isShellIntegrationModule to improve clarity.
const shellIntegrationMoved = satisfies(vscode.version, ">=1.102", {

src/utils.ts:13

  • Add unit tests to cover both branches of this version check (>=1.102 and <1.102) to verify the script path resolution (.psm1 vs .ps1) works as expected.
const shellIntegrationMoved = satisfies(vscode.version, ">=1.102", {

@andyleejordan andyleejordan merged commit 2111428 into main Jun 17, 2025
8 checks passed
@andyleejordan andyleejordan deleted the module branch June 17, 2025 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants