Skip to content

Conversation

andyleejordan
Copy link
Member

This custom task can't use an org-scoped feed, so I had to make a project-scoped one just for it. Which is only necessary because the package still isn't cached.

Also remove the KS3 setting as it's no longer compliant, and an out-of-date TODO.

This custom task can't use an org-scoped feed,
so I had to make a project-scoped one just for it.
Which is only necessary because the package still isn't cached.
@andyleejordan andyleejordan requested a review from a team as a code owner September 10, 2025 19:43
@Copilot Copilot AI review requested due to automatic review settings September 10, 2025 19:43
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the marketplace publishing step by updating the Azure DevOps feed configuration and removes non-compliant settings. The changes address a specific issue where the custom task requires a project-scoped feed instead of an org-scoped one.

  • Updated the npm feed name from npmjs to vsce for marketplace publishing
  • Removed the non-compliant KS3 network setting from the Windows host configuration
  • Cleaned up an outdated TODO comment about esbuild support for tests

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
.pipelines/vscode-powershell-OneBranch.yml Updates feed configuration and removes non-compliant network setting
vscode-powershell.build.ps1 Removes outdated TODO comment about esbuild test support

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@andyleejordan andyleejordan enabled auto-merge (rebase) September 10, 2025 19:43
@andyleejordan andyleejordan merged commit 8f02e20 into main Sep 10, 2025
8 checks passed
@andyleejordan andyleejordan deleted the vsce branch September 10, 2025 19:47
@andyleejordan andyleejordan added the Ignore Exclude from the changelog. label Sep 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ignore Exclude from the changelog.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant