Fix bug where paused work queues getting unpaused and set to active on worker poll #14082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
collincchoy
commented
Jun 17, 2024
| @@ -374,7 +374,7 @@ async def get_scheduled_flow_runs( | |||
|
|
|||
| polled_work_queue_ids = [wq.id for wq in work_queues] | |||
| ready_work_queue_ids = [ | |||
| wq.id for wq in work_queues if wq.status != WorkQueueStatus.READY | |||
There was a problem hiding this comment.
when wq.status == WorkQueueStatus.PAUSED, this is erroneously setting those work queues to READY
There was a problem hiding this comment.
Great find! Do we have a simiarl issue in Prefect Cloud as well, or does it use a different mechanism?
There was a problem hiding this comment.
Should be good.
I'm still looking into another closely related issue, but this should fix one bug.
chrisguidry
approved these changes
Jun 17, 2024
| @@ -374,7 +374,7 @@ async def get_scheduled_flow_runs( | |||
|
|
|||
| polled_work_queue_ids = [wq.id for wq in work_queues] | |||
| ready_work_queue_ids = [ | |||
| wq.id for wq in work_queues if wq.status != WorkQueueStatus.READY | |||
There was a problem hiding this comment.
Great find! Do we have a simiarl issue in Prefect Cloud as well, or does it use a different mechanism?
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug (regression from #13117) where a paused work queue gets automatically unpaused on worker poll.
Closes #13935
Checklist
<link to issue>"maintenance,fix,feature,enhancement,docs.For documentation changes:
mint.jsonfor files that are removed or renamed.For new functions or classes in the Python SDK:
docs/mint.jsonnavigation.