Fix stale deployment statuses #14095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base automatically changed from
fix/paused-work-queues-auto-unpaused-to-active
to
main
June 17, 2024 20:54
collincchoy
commented
Jun 17, 2024
collincchoy
commented
Jun 17, 2024
| @@ -1845,28 +1845,52 @@ async def test_updates_last_polled_on_a_multiple_work_queues( | |||
| assert work_queue.last_polled is None | |||
|
|
|||
| async def test_updates_last_polled_on_a_full_work_pool( | |||
There was a problem hiding this comment.
changes to this test adds coverage that all requested work queues' last polled field gets updated regardless of their status which covers my changes to the polled_work_queue_ids up in the app code.
collincchoy
commented
Jun 17, 2024
| assert work_queue.last_polled > now | ||
|
|
||
| async def test_updates_work_queue_status_on_a_full_work_pool( | ||
| self, client, session, work_queues, work_pools | ||
| async def test_updates_statuses_on_a_full_work_pool( |
There was a problem hiding this comment.
this test now covers that both work queue statuses and deployment statuses are updated here.
There's one more pre-existing test after this one that checks a single deployment is updated correctly but this covers that multiple relevant deployments are updated regardless of work queue statuses
serinamarie
reviewed
Jun 20, 2024
| ) | ||
|
|
||
| background_tasks.add_task( | ||
| mark_deployments_ready, | ||
| work_queue_ids=ready_work_queue_ids, | ||
| work_queue_ids=[wq.id for wq in work_queues], |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar (but different) to #14082 - this PR fixes a separate issue where Deployment statuses aren't being updated correctly. In particular, a work pool + queue with a running worker does not update a newly created deployment to READY.
Closes #13869
See #14097 for 2.x port.
Checklist
maintenance,fix,feature,enhancement,docs.<link to issue>"mint.json.