Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installs the vuepress-plugin-code-copy plugin and replaces the previo… #1482

Merged
merged 7 commits into from
Sep 10, 2019

Conversation

znicholasbrown
Copy link
Contributor

…us code copy plugin.

Thanks for contributing to Prefect!

Please describe your work and make sure your PR:

  • adds new tests (if appropriate)
  • updates CHANGELOG.md (if appropriate)
  • updates docstrings for any new functions or function arguments, including docs/outline.toml for API reference docs (if appropriate)

Note that your PR will not be reviewed unless all three boxes are checked.

What does this PR change?

It installs a better plugin for the copy button in code blocks... adds some nice (customizable) animations and user feedback!

Why is this PR important?

It's important to provide users with feedback when they perform an action.

@codecov
Copy link

codecov bot commented Sep 10, 2019

Codecov Report

Merging #1482 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Copy link
Member

@cicdw cicdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool - thanks for keeping on top of our docs-vuepress hooks @znicholasbrown!!

@jlowin
Copy link
Member

jlowin commented Sep 10, 2019

Worth noting that @znicholasbrown published this plugin himself: https://github.com/znicholasbrown/vuepress-plugin-code-copy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants