Disable non native modules on PS8.0 and onward

classes/UpgradeTools/CoreUpgrader/CoreUpgrader80.php

@@ -31,7 +31,9 @@
 use PrestaShop\Module\AutoUpgrade\UpgradeException;
 use PrestaShop\PrestaShop\Core\CommandBus\CommandBusInterface;
 use PrestaShop\PrestaShop\Core\Domain\MailTemplate\Command\GenerateThemeMailTemplatesCommand;
+use PrestaShop\PrestaShop\Core\Domain\Module\Command\BulkToggleModuleStatusCommand;
 use PrestaShop\PrestaShop\Core\Exception\CoreException;
+use PrestaShop\PrestaShop\Adapter\Module\Repository\ModuleRepository;
 
 class CoreUpgrader80 extends CoreUpgrader
 {
@@ -100,4 +102,10 @@ protected function upgradeLanguage($lang)
 
         // TODO: Update AdminTranslationsController::addNewTabs to install tabs translated
     }
+
+    protected function disableCustomModules()
+    {
+        $moduleRepository = new ModuleRepository(_PS_ROOT_DIR_, _PS_MODULE_DIR_);
+        $this->container->getModuleAdapter()->disableNonNativeModules80($this->pathToUpgradeScripts, $moduleRepository);
+    }
 }

classes/UpgradeTools/ModuleAdapter.php

@@ -54,6 +54,8 @@ class ModuleAdapter
 
     private $commandBus;
 
+    private $moduleRepository;
+
     public function __construct($db, $translator, $modulesPath, $tempPath, $upgradeVersion, ZipAction $zipAction, SymfonyAdapter $symfonyAdapter)
     {
         $this->db = $db;
@@ -99,6 +101,21 @@ public function getCommandBus()
         return $this->commandBus;
     }
 
+    /**
+     * Available since PrestaShop 8.0
+     */
+    public function getModuleRepository()
+    {
+        if (null === $this->moduleRepository) {
+            $this->moduleRepository = $this->symfonyAdapter
+                ->initAppKernel()
+                ->getContainer()
+                ->get('prestashop.adapter.module.repository.module_repository');
+        }
+
+        return $this->moduleRepository;
+    }
+
     /**
      * Upgrade action, disabling all modules not made by PrestaShop.
      *
@@ -112,6 +129,12 @@ public function disableNonNativeModules($pathToUpgradeScripts)
         deactivate_custom_modules();
     }
 
+    public function disableNonNativeModules80($pathToUpgradeScripts, $moduleRepository)
+    {
+        require_once $pathToUpgradeScripts . 'php/deactivate_custom_modules.php';
+        deactivate_custom_modules80($moduleRepository);
+    }
+
     /**
      * list modules to upgrade and save them in a serialized array in $this->toUpgradeModuleList.
      *

tests/phpstan/phpstan-latest.neon

@@ -2,6 +2,8 @@ includes:
 	- %currentWorkingDirectory%/tests/phpstan/phpstan.neon
 
 parameters:
+	excludes_analyse:
+		- ./../../classes/UpgradeTools/CoreUpgrader/CoreUpgrader80.php
 	ignoreErrors:
 		- '#Access to an undefined property Module::\$installed.#'
 		- '#Call to method fetchLocale\(\) on an unknown class PrestaShop\\PrestaShop\\Core\\Cldr\\Update.#'

upgrade/php/deactivate_custom_modules.php

@@ -95,3 +95,39 @@ function deactivate_custom_modules()
 
     return $return;
 }
+
+function deactivate_custom_modules80($moduleRepository)
+{
+    $nonNativeModulesList = $moduleRepository->getNonNativeModules();
+
+    $return = Db::getInstance()->execute(
+        'UPDATE `' . _DB_PREFIX_ . 'module` SET `active` = 0 WHERE `name` IN (' . implode(',', array_map('add_quotes', $nonNativeModulesList)) . ')'
+    );
+
+    $nonNativeModules = \Db::getInstance()->executeS('
+        SELECT *
+        FROM `' . _DB_PREFIX_ . 'module` m
+        WHERE name IN (' . implode(',', array_map('add_quotes', $nonNativeModulesList)) . ') ');
+
+    if (!is_array($nonNativeModules) || empty($nonNativeModules)) {
+        return $return;
+    }
+
+    $toBeUninstalled = [];
+    foreach ($nonNativeModules as $k => $aModule) {
+        $toBeUninstalled[] = (int) $aModule['id_module'];
+    }
+
+    if (empty($toBeUninstalled)) {
+        return $return;
+    }
+
+    $sql = 'DELETE FROM `' . _DB_PREFIX_ . 'module_shop` WHERE `id_module` IN (' . implode(',', array_map('add_quotes', $toBeUninstalled)) . ') ';
+    $return &= Db::getInstance()->execute($sql);
+
+    return $return;
+}
+
+function add_quotes($str) {
+    return sprintf("'%s'", $str);
+}