Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update upgrade.js #906

Open
wants to merge 214 commits into
base: 6.x
Choose a base branch
from
Open

Update upgrade.js #906

wants to merge 214 commits into from

Conversation

fer-av
Copy link

@fer-av fer-av commented Sep 21, 2024

versionNumberRegex Not define!!!

Questions Answers
Description? No anda Expert mode -> Canal: directorio local
Type? bug fix
BC breaks? yes
Deprecations? yes
Fixed ticket?
Sponsor company eflyshop
How to test? hice el cambio y actualice mi sitio!

Hlavtox and others added 30 commits September 4, 2024 10:34
@Hlavtox
Modify varchar limits
0bc0b8e
@ps-jarvis
New translations modulesautoupgradeadmin.en.xlf (French)
2c4db6b
@ps-jarvis
New translations modulesautoupgradeadmin.en.xlf (Spanish)
3ae0bc9
@ps-jarvis
New translations modulesautoupgradeadmin.en.xlf (Italian)
fa0ba97
@ps-jarvis
New translations modulesautoupgradeadmin.en.xlf (Dutch)
07877e9
@ps-jarvis
New translations modulesautoupgradeadmin.en.xlf (Polish)
62b1306
@ps-jarvis
New translations modulesautoupgradeadmin.en.xlf (Portuguese)
1b204fa
@ps-jarvis
New translations modulesautoupgradeadmin.en.xlf (Russian)
58809c4
@Quetzacoalt91
Merge pull request PrestaShop#869 from Hlavtox/pr-35882
a95faf8 
Unify varchar limits
@Quetzacoalt91
Merge pull request PrestaShop#871 from PrestaShop/l10n_dev
331b4db 
New Crowdin updates
Translation catalog update for version dev 2024-09-05-10_25_33
dc1fe5f
Improve runPhpQuery readability and parameters extraction. Add unit t…
8b055e6 
…ests
@Quetzacoalt91
Merge pull request PrestaShop#874 from M0rgan01/runPhpQuery-improvements
4a50c22 
Improve "runPhpQuery" method
Translation catalog update for version dev 2024-09-05-15_10_46
94654d2
@Hlavtox
Create tables only if they don't exist
06d5673
@Hlavtox
Add columns only when not exist, update if they do
227f585
@Hlavtox
Improve dropping columns on some places
1593064
@Hlavtox
Escape quotes instead of using double ones
c8b38b6
@Quetzacoalt91
Merge pull request PrestaShop#873 from PrestaShop/translation-extraction
20e3d0c 
Translation catalog update
@Quetzacoalt91
Merge pull request PrestaShop#875 from PrestaShop/6.x
1d1b3d1 
Merge 6.x into dev
@ps-jarvis
New translations modulesautoupgradeadmin.en.xlf (French)
f862242
@ps-jarvis
New translations modulesautoupgradeadmin.en.xlf (Spanish)
a637f59
@ps-jarvis
New translations modulesautoupgradeadmin.en.xlf (Czech)
77a0ccc
@ps-jarvis
New translations modulesautoupgradeadmin.en.xlf (Italian)
56e9fba
@ps-jarvis
New translations modulesautoupgradeadmin.en.xlf (Dutch)
ff75bd1
@ps-jarvis
New translations modulesautoupgradeadmin.en.xlf (Polish)
d5dc646
@ps-jarvis
New translations modulesautoupgradeadmin.en.xlf (Portuguese)
1e0afbc
@ps-jarvis
New translations modulesautoupgradeadmin.en.xlf (Russian)
da59db3
@Hlavtox
Fix unescaped query
9398a8a
Drop server performance configuration
815b581
ga-devfront and others added 22 commits September 19, 2024 10:19
@ga-devfront
refacto: page controllers
bdc05fc
@ga-devfront
fix: php stan errors
9302b16
@ga-devfront
fix: cs fixer errors
103672d
@tblivet @ga-devfront
fix: storybook and clean twig
e4039ed
@ga-devfront
feat: add LocalArchiveRepository tests
5f262ed
@ga-devfront
feat: add AssetsEnvironment tests
90c7f50
@ga-devfront
fix: tests
78df1ec
@Quetzacoalt91
Add a bootstrap file to force the autoloader to load our classes prio…
4d92756 
…r analyze
@ga-devfront
fix: cs fixer
d04c66b
@ga-devfront
fix: review feedback
a18bd54
@ga-devfront
fix: rename update steps
c6baef6
@ga-devfront
feat: add updateSteps tests
bbcef14
@ga-devfront
fix: cs fixer
caf1035
@ga-devfront
feat: change h1 title to h2 into twig files
abe05e2
@ga-devfront
feat: add getStepsParams into update controllers
68abddd
@ga-devfront
feat: remove release date from twig
76b272a
@ga-devfront
fix: cs fixer
ea3afcf
@Quetzacoalt91
Merge pull request PrestaShop#895 from ga-devfront/feat/update-page-1
eb3a05e 
Add: Update page step version choice
Translation catalog update for version dev 2024-09-19-15_40_12
710c3f1
@Hlavtox
Merge pull request PrestaShop#853 from Hlavtox/strengthten-upgrade
5e2cee1 
Strengthten upgrade process
@Quetzacoalt91
Merge pull request PrestaShop#903 from PrestaShop/translation-extraction
3d63e04 
Translation catalog update
@fer-av
Update upgrade.js
7602da4 
versionNumberRegex Not define!!!
@ps-jarvis
Copy link
Collaborator

Hello @fer-av!

This is your first pull request on autoupgrade repository of the PrestaShop project.

Thank you, and welcome to this Open Source community!

Seb33300
Seb33300 suggested changes Sep 22, 2024
View reviewed changes
js/upgrade.js Outdated Show resolved Hide resolved
@fer-av @Seb33300
Update js/upgrade.js
293e023 
Co-authored-by: Sébastien Alfaiate <seb33300@hotmail.com>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 22, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot
C Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@M0rgan01
Copy link
Contributor

M0rgan01 commented Sep 23, 2024 •
edited
Loading

@fer-av Hello! Thanks for the contribution, and for restoring the missing variable!

However, the upgrade.js file will be completely refactored into typescript for the introduction of a new UI on the next major release.

On the other hand it is possible to target the 6.x branch, which may have minor or patch releases in the future.

@Quetzacoalt91 Quetzacoalt91 changed the base branch from dev to 6.x September 25, 2024 14:56
@Quetzacoalt91
Copy link
Member

Quetzacoalt91 commented Sep 25, 2024 •
edited
Loading

This variable is indeed not used anymore in the upgrade.js file on the dev branch (https://github.com/PrestaShop/autoupgrade/pull/902/files#diff-35ef954ff7799e931a3e99706a3bca463d56a3c77729d5755311b9ebcb93c1acL837), and the incoming version will provide a new UI.

I changed the base branch for 6.x but it requires a rebase on your end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Seb33300 Seb33300 Seb33300 requested changes

Assignees
No one assigned
Labels
waiting for author
Projects
PR Dashboard
Status: Ready for review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@fer-av @ps-jarvis @M0rgan01 @Quetzacoalt91 @Seb33300 @Hlavtox @ga-devfront @Progi1984 @tblivet