-
Notifications
You must be signed in to change notification settings - Fork 479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reusable custom Form Types reference #245
Conversation
|
||
* [CountryChoiceType](country-choice) | ||
|
||
* [MeterialChoiceTableType](meterial-choice-table) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* [MeterialChoiceTableType](meterial-choice-table) | |
* [MaterialChoiceTableType](material-choice-table) |
you have several errors like this :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks
{ | ||
$builder | ||
->add('name', TextType::class) | ||
## this would provide default choices, which are the choices from PrestaShhop database |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
## this would provide default choices, which are the choices from PrestaShhop database | |
## this would provide default choices, which are the choices from PrestaShop database |
## Form types reference | ||
|
||
While developing on PrestaShop you can use any form field type that is provided by Symfony framework. | ||
More about Symfony field types: https://symfony.com/doc/current/reference/forms/types.html. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More about Symfony field types: https://symfony.com/doc/current/reference/forms/types.html. | |
More about Symfony form types: https://symfony.com/doc/current/reference/forms/types.html. |
It's called form types in Symfony docs, so better to refer to the same name for consistency.
|
||
* [TranslatableType](translatable) | ||
|
||
* [TranslateTextType](translate-text) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TranslateTextType
is deprecated, should we still document it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess not, ill remove it.
### CategoryChoiceTreeType | ||
|
||
CategoryChoiceTreeType is a child of [MaterialChoiceTreeType](material-choice-tree), it extends parent options | ||
with options listed bellow. It is used to display category tree selection box and requires |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is used to display category tree selection box
IMO a screenshot of the rendered form type would make it easier for developers to understand what they can expect from each form type.
|
||
| Option | Type (default value) | Description | | ||
| ----------------------------| ------------------------------------------|-------------------------------------------------| | ||
| **choices_tree** | **array**(choices list provided by CategoryTreeChoiceProvider.php)| Values to choose from in choices tree | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(choices list provided by CategoryTreeChoiceProvider.php)
IMO something like (array with all available category choices) would sound better.
663c2ea
to
0970bee
Compare
@matks review when you have time. |
This is no more in WIP :) ? |
Yeah, but I think there a space for improvements, so give your feedback. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor mistake, one more emphasis
Congrats for the hard work on this doc 😄
src/content/1.7/development/components/form/types-reference/translatable.md
Outdated
Show resolved
Hide resolved
src/content/1.7/development/components/form/types-reference/translatable.md
Outdated
Show resolved
Hide resolved
Co-Authored-By: sarjon <jonusas.sarunas@gmail.com>
Co-Authored-By: sarjon <jonusas.sarunas@gmail.com>
@matks all comments addressed. |
Thank you @zuk3975 and @sarjon for the hard work |
No description provided.