Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve VS Code Dark Plus theme accuracy #103

Merged
merged 6 commits into from
Aug 28, 2020
Merged

Improve VS Code Dark Plus theme accuracy #103

merged 6 commits into from
Aug 28, 2020

Conversation

karlhorky
Copy link
Contributor

@karlhorky karlhorky commented Aug 26, 2020

Hi, a quick fix for a number of color inaccuracies in the VS Code Dark Plus theme.

Try out the theme switcher dropdown on the website below for a detailed overview of the changes:

Website: https://objective-williams-02e373.netlify.app/
Repo: https://github.com/karlhorky/prismjs-vs-code-dark-theme-fix

Preview (may be outdated):

Old

Screen Shot 2020-08-26 at 17 56 17

New

Screen Shot 2020-08-27 at 21 25 29

@RunDevelopment
Copy link
Member

That looks really good!

Could you please run the npx gulp screenshot command to update the screenshot? After that, we can merge this.


Also, you might be interested to know that Prism also has a regex language that will add itself to JS, JSX, TS, and TSX. I gave it some highlighting a while ago but it's far from ideal.

Also also, should I add an alias for control-flow keywords (e.g. if, else, try, return, aka the purple ones) to JS Extras?

@karlhorky
Copy link
Contributor Author

Also also, should I add an alias for control-flow keywords (e.g. if, else, try, return, aka the purple ones) to JS Extras?

That would be great, cheers! This along with PrismJS/prism#2528 would probably cover a lot of the remaining missing things.

Prism also has a regex language that will add itself to JS, JSX, TS, and TSX

Added to the demo, thanks! I also added a new escape token color.

Could you please run the npx gulp screenshot command to update the screenshot?

Sure, done!

@karlhorky
Copy link
Contributor Author

Also styled the .token.keyword.control-flow classes: 6449e45

@karlhorky
Copy link
Contributor Author

@RunDevelopment Added the color changes from .token.imports .token.maybe-class-name and .token.exports .token.maybe-class-name (PrismJS/prism#2528 and PrismJS/prism#2533).

I guess this PR is now ready to go?

@RunDevelopment RunDevelopment merged commit fa210d3 into PrismJS:master Aug 28, 2020
@RunDevelopment
Copy link
Member

Thank you for contributing @karlhorky!

@karlhorky
Copy link
Contributor Author

Glad to help! Thanks for the merge and your tireless work on this!! 💯

@karlhorky karlhorky deleted the patch-1 branch August 28, 2020 16:12
@karlhorky
Copy link
Contributor Author

@RunDevelopment would it be possible to get a new version published to npm with these changes? Version 1.4.0 does not have them...

@RunDevelopment
Copy link
Member

@mAAdhaTTah Could you please handle the release? The next version will be 1.4.1, I think.

@mAAdhaTTah
Copy link
Member

@RunDevelopment @karlhorky done. v1.4.1 is live in npm.

@karlhorky
Copy link
Contributor Author

Thanks @RunDevelopment @mAAdhaTTah !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants