Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Javascript // comments are not greedy #1337

Closed
CoenraadS opened this issue Mar 7, 2018 · 4 comments
Closed

Javascript // comments are not greedy #1337

CoenraadS opened this issue Mar 7, 2018 · 4 comments
Assignees
@Golmote
Labels
enhancement language-definitions

Comments

@CoenraadS
Copy link 

if (1 == 1) {
    // gulp.watch('./src/**/*.js', ['move']); 
}

It stops the comment after */

image

It is getting confused by /**/ inside of //
@Golmote Golmote closed this as completed in b98e5b9 Mar 7, 2018
@CoenraadS
Copy link
Author

I really appreciate your work man!

@Golmote
Copy link
Contributor

Golmote commented Mar 7, 2018

Happy to help when I can! ;)

Golmote added a commit that referenced this issue Mar 8, 2018
@Golmote
Revert "C-like: Change order of comment patterns and make multi-line …
cebacdf 
…one greedy. Fix #1337"

This reverts commit b98e5b9
@Golmote Golmote reopened this Mar 8, 2018
@Golmote
Copy link
Contributor

Golmote commented Mar 8, 2018

I reverted cebacdf. Because the use-case for single line comment inside multi-line comment is more common than the opposite.

At the moment, we can't have both this and #1340. So we'll stick with the previous behaviour for now, while I try to find a way.

@Golmote Golmote self-assigned this Mar 26, 2018
@Golmote
Copy link
Contributor

Golmote commented Mar 26, 2018

Hopefully both will stay fixed now!

@snyk-bot snyk-bot mentioned this issue Aug 11, 2020
Merged
@snyk-bot snyk-bot mentioned this issue Aug 28, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Golmote Golmote

Labels
enhancement language-definitions
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Golmote @CoenraadS