Avoid TypeError when mapper is undefined #2167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harigopal
added a commit
to pupilfirst/pupilfirst
that referenced
this pull request
Jan 9, 2020
This was done using a yarn "rejuvenation" script: https://gist.github.com/pftg/fa8fe4ca2bb4638fbd19324376487f42 This avoid CVE-2019-10747 in the set-value package. I was also forced to fork the PrismJS library to fix a bug related to improper use of the ternary operator in one of its plugins. I've submitted a PR for that: PrismJS/prism#2167
mahesh-krishnakumar
pushed a commit
to pupilfirst/pupilfirst
that referenced
this pull request
Jan 9, 2020
This was done using a yarn "rejuvenation" script: https://gist.github.com/pftg/fa8fe4ca2bb4638fbd19324376487f42 This avoid CVE-2019-10747 in the set-value package. I was also forced to fork the PrismJS library to fix a bug related to improper use of the ternary operator in one of its plugins. I've submitted a PR for that: PrismJS/prism#2167
mAAdhaTTah
requested review from
RunDevelopment
and removed request for
RunDevelopment
|
Thanks for the PR! Make sure you run @RunDevelopment This seems like enough of an issue that we should consider cutting another release soon. Thoughts? |
RunDevelopment
approved these changes
Jan 9, 2020
|
@mAAdhaTTah I agree. I'll get the changelog ready. Maybe we could set up a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A ternary operation in the
prism-custom-class.jsfile needs to be wrapped with parentheses for it to be evaluated properly. In it's current form, it's throwing a TypeError.