Reset Clipboard to undefined if native code #1206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chrome now ships with a window.Clipboard built in, which breaks this check. This ensures we're not grabbing the built-in Clipboard and definitely have the correct package version. Fixes PrismJS#1181.
mAAdhaTTah
force-pushed
the
issue/1181-fix-clipboard-check
branch
from
99d4008
to
b3304e3
Compare
|
i waiting this PR, i have error on my product because this problem |
|
@Golmote How do you feel about this approach? |
|
@mAAdhaTTah Hi, Currently my solution for my product is remove your copy-to-clipboard plugin, so sad :( . But i hope it will work well later |
|
Well, I can't say it's pretty. If it fixes the issue, that's ok for me, though. Hopefully this will be a temporary fix. |
|
I'm inclined to doubt it'll be temporary, as I haven't seen any movement from the developer on the Clipboard.js repository. I do think it'll be stable, so I don't think we'll need to remove it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chrome now ships with a window.Clipboard built in, which breaks
this check. This ensures we're not grabbing the built-in
Clipboard and definitely have the correct package version.
Fixes #1181.