-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve recognition of constants in PHP #1688
Conversation
I don't think it's a good idea to say that any word which isn't highlighted as anything else should be a constant. Let's say there is a feature of PHP which Prism doesn't support (yet). All of the keywords/names related to this feature will be highlighted as constants. I encourage you to play around with the examples on the PHP.net page and see for yourself what would be highlighted as constants. But apart from that, isn't it a naming convention to not use lowercase characters for constants? |
That’s the way PHP behaves in some circumstances, such as Prism definitely shouldn’t mark unsupported elements as constants. OK, let’s stick with PSR‑1, not language itself, i. e., underscore as a word separator only, no lower‑case letters. Should we have single‑letter constants ( |
Sure! |
Thank you for contributing! |
Thank you! But it’s sad that the PR was merged before Travis CI has finished building :( |
Don't worry about that. |
OK, thank you! |
Resolves #1687.