Tests: Additional checks for Prism functions #1803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mAAdhaTTah
reviewed
Mar 24, 2019
|
This feels really hacky but it works and it even gets us IDE support; The new pseudo require. |
mAAdhaTTah
reviewed
Mar 24, 2019
mAAdhaTTah
approved these changes
Mar 24, 2019
This was referenced Oct 26, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds some additional checks for the inputs of some Prism functions.
They work by replacing a function to test with another function calling both the test code and the original function.
This allows us to add complex checks without adding weight to Prism core.
Right now, I added checks for
Prism.languages.extendandPrism.languages.insertBefore.This resolves #1717.