Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Inline color plugin #2007

Merged
merged 10 commits into from
Sep 3, 2019
Merged

Added Inline color plugin #2007

merged 10 commits into from
Sep 3, 2019

Conversation

RunDevelopment
Copy link
Member

This implements #1987.

The new plugin uses color and hexcode tokens to detect colors and work for all languages which detect these token. Right now, this is only CSS and SCSS.

Example

image

mAAdhaTTah
mAAdhaTTah previously approved these changes Sep 3, 2019
View reviewed changes
Copy link
Member

@mAAdhaTTah mAAdhaTTah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@mAAdhaTTah mAAdhaTTah dismissed their stale review September 3, 2019 15:51

Need to decide on data attr vs class

@RunDevelopment RunDevelopment merged commit 8403e45 into PrismJS:master Sep 3, 2019
@RunDevelopment RunDevelopment deleted the inline-color branch September 3, 2019 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mAAdhaTTah mAAdhaTTah mAAdhaTTah approved these changes

Assignees
No one assigned
Labels
needs review new plugin plugins
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RunDevelopment @mAAdhaTTah